Max Inden
Max Inden
@omansfeld finished this in https://github.com/mozilla/neqo/pull/3233. :pray:
I don't see a way around the two `Option`s. The inner `Option` will notify all other owners of the qlog, that the log has errored, the outer `Option` prevents the...
Yes please @larseggert. Thanks.
@larseggert have you seen this CI failure in `mtu` before? ``` ================================================================= ==8681==ERROR: LeakSanitizer: detected memory leaks Direct leak of 152 byte(s) in 1 object(s) allocated from: #0 0x000105d4d86c in...
> Am wondering if we should cut a neqo release soon before there is more divergence. I was planning to cut a new release once https://github.com/mozilla/neqo/pull/2492 is merged. @larseggert I...
Wasn't aware of this. Cool. In favor once fix is released.
Thanks for exploring the change. This adds a lot of noise. Thus I suggest only proceeding here in case it has a significant performance win. What will we do on...
Would work, yes. That said, I think we should make recording a qlog as low-friction as possible. Currently one has to [simply set a pref](https://firefox-source-docs.mozilla.org/networking/http/logging.html#how-to-enable-quic-logging). Shipping a custom build instead,...
In regards to feature flagging, @larseggert what do you think of https://github.com/mozilla/neqo/pull/3129/ instead? It is less intrusive, and should provide the same performance characteristics as this pull request. If you...
Can you expand on these 3 points @LPardue. Sorry in case I am missing something obvious. > Thats an easy way to surprise users of the library Say quiche grants...