Max Inden
Max Inden
Above sounds good! For ECN CE, we currently only have: https://glam.telemetry.mozilla.org/fog/probe/networking_http_3_ecn_ce_ect0_ratio_received/explore?
> I think it would make sense if this lands closely after [#3086](https://github.com/mozilla/neqo/pull/3086) so we can get a bunch of stats into Firefox at once without having to do multiple...
Optimized _Upload_ only thus far. > 1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. > > time: [1.2891 s 1.2983 s 1.3077 s] > thrpt: [76.469 MiB/s 77.023 MiB/s 77.571 MiB/s]...
Introduced the same optimizations to `neqo-server`. In addition I removed the memory copy, now allocating each datagram of a GSO train into a single contiguous `Vec` right away. Result looks...
@larseggert the `neqo-transport/bench/transfer.rs` benchmarks use the `test-fixtures/src/sim` `Simulator`. The `Simulator` only processes a single datagram at a time. https://github.com/mozilla/neqo/blob/37c3aeebb79aef9f9649c54c3bbfae84fee523b3/test-fixture/src/sim/mod.rs#L206 Let me see whether I can change that as part of...
This pull request is ready for review. Note that benchmark results are inaccurate due to https://github.com/mozilla/neqo/pull/2743.
Thanks for the quick review! For the record, MacOS failure is due to different `EMSGSIZE` handling in `quinn-udp` (https://github.com/quinn-rs/quinn/pull/2199). Will push a simple patch.
> For the record, MacOS failure is due to different `EMSGSIZE` handling in `quinn-udp` ([quinn-rs/quinn#2199](https://github.com/quinn-rs/quinn/pull/2199)). Will push a simple patch. Will be fixed in https://github.com/mozilla/neqo/pull/2746.
Yes, ready to merge from my end. We have a couple of benchmark regressions. Explainer for each: > 1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. > > time: [650.03 ms...
> please do issues for the missing bits? I assume you are fine with the following pull requests tracking the progress. Let me know if you want additional GitHub issues....