Max Inden
Max Inden
Without pacing, this pull request outperforms `main`: ``` ➜ neqo-bin git:(main) ✗ critcmp main main-no-pacing 32k 32k-no-pacing -f "Download" --list 1-conn/1-100mb-resp (aka. Download)/client ------------------------------------------ 32k-no-pacing 1.00 114.8±49.78ms 871.3 MB/sec main-no-pacing...
This is ready for a review. https://github.com/mozilla/neqo/pull/2035 resolved the performance regressions. In addition, as expected, this now improves the Download benchmark: > 1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. >...
If we do want to tackle GSO in the future, this can serve as guidance. That said, best to start fresh. Work tracked in https://github.com/mozilla/neqo/issues/1693. Closing here.
> Are we currently running with the OS defaults? In Firefox we attempt to set it to 1 MiB. I wasn't aware of this until today trying to add another...
As far as I can tell [we only alter the receive buffer](https://searchfox.org/mozilla-central/rev/01aaa47e62a2015e7641f26ab0bc2bb00ab579b8/netwerk/protocol/http/HttpConnectionUDP.cpp#107-115), not the send buffer. I am not familiar enough with the code base to know for sure. >...
Keeping this open to track send buffer increase experimentation.
Frame stats have been introduced in https://github.com/mozilla/neqo/pull/1011. https://phabricator.services.mozilla.com/D228295 exposed them via Glean. One can explore the metric here: https://glam.telemetry.mozilla.org/fog/probe/networking_http_3_quic_frame_count/explore?aggType=avg  > count number of send/receive DATA_BLOCKED frames with a unique...
:+1: we will need an `Encoder` encoding into an externally managed buffer (send buffer) as part of https://github.com/mozilla/neqo/issues/1693 as well.
Thanks @michalkucharczyk for reporting. > @mxinden Do you know why that was implemented this way? I don't unfortunately. I am not sure what the best next step is. - In...
I am not aware of any updates. I am fine with any of the two solutions suggested in https://github.com/libp2p/rust-libp2p/issues/3390#issuecomment-1443154305. @bkchr are you still seeing this in the wild?