Max Inden

Results 899 comments of Max Inden

As long as we are statically allocating each datagram in a `Vec` anyways, what is the benefit of serving them outside of our event system? We need a notification (i.e....

> In reality, the set of transports we can perform address translation on is limited by the transports that the `multiaddr::Protocol` enum supports. Thus, delegating this to the actual `Transport`...

> If we have `port_reuse` enabled in the transport, these ports will already be the same I am not sure this is true. In the case of a NAT in...

> If we don't have port-reuse enabled, is `address_translation` of any use? Even if the user configured port-forwarding, we have no idea what port they forwarded things to. We might...

Great debugging work! +1 for checking the kernel version at runtime. I can not think of a better option.

> Introduce a fake no-op `bench` feature to `neqo_glue`. I will go with this for now in https://phabricator.services.mozilla.com/D234901.

> Can we keep a bidirectional transfer as part of the benches? For sure. I will do a follow-up pull request. Sounds good?

I was wrong. Updated the PR description. Still worth merging. > While a bug, this does not fix #2538, given that the HTTP3 server would simply ignore the `/104857600` URL...

Closing here in favor of https://github.com/mozilla/neqo/issues/2792.

Oh, yes, of course, you are right. For the record, our current MSRV: https://github.com/mozilla/neqo/blob/318b611512cb40235fc251a4870b43ecfd4a71fa/Cargo.toml#L29