Max Inden

Results 899 comments of Max Inden

> I tried using `()` as the label set for a family, like `Family`. What is your reasoning for not using a plain `Histogram`?

One solution could be to only add a `,` here in case the previous label has a length larger than `0`. https://github.com/prometheus/client_rust/blob/6b7a3458b47a406d15f2ae0a678c611969c4645d/src/encoding/text.rs#L277-L285

> Tangentially related, but I noticed that `&str` also implements encode - does that assume that you _must_ have the `&str` be equal to `"label_name=\"label_value\"`? I'm assuming that if you...

I agree. Today I am using `Encode` to encode the following: - Label pair - Label key - Label value - Metric value Each of these use-cases should probably use...

> Thank your for the project :) Glad that it is useful. :heart: > I found myself missing an implementation of the Summary metric, so decided to file an issue...

Done. Thanks @palash25. Let me know in case you need any help.

@palash25 unfortunately I don't have any experience with quantile algorithms, neither in general nor in Rust. Thus no preference. Sorry. > I found one that implements CKMS would it be...

I am sorry for the late reply. This is a neat solution. I did not think about abstracting a `Registry`. Unfortunately a user can not use the `Collector` abstraction in...

Cross referencing alternative proposal: https://github.com/prometheus/client_rust/pull/82

As you stated above, a clean solution is not possible today, i.e. would require some changes within `prometheus-client`. I am not opposed to supporting this use-case, though I need to...