Max Inden

> The issue is that they all share a few (relatively) expensive initial steps, and if I'll gather the data for each metric separately I'll be repeating the steps for...

> * Have a new Collector trait that looks something like: > > > ```rust > trait Collector Self::List: Iterator

@dovreshef are you still interested in contributing the `Collector` pattern? :)

Cross referencing proposal for `Collector` here: https://github.com/prometheus/client_rust/pull/82

I wonder whether moving to `parking_lot` has any implications on this crate's support for WASM. Gathering the WASM experts here. Do you have any opinions on this? Do we need...

For the record, this patch does not seem to have a significant impact on benchmarks: ``` ➜ critcmp master parking_lot group master parking_lot ----- ------ ----------- counter family with Vec...

> Note: It looks like parking_lot actually has WASM support. When compiled without (experimental) WASM-atomic support, it just panics when trying to park, but that's fine. Adding to this: >...

Unless there are any objections, I will merge and release this tomorrow or next week. Thanks for the input everyone!

:wave: Hi @ackintosh, > I think I need to implement custom encoder, translate metrics to JSON format. Yes, you would need to implement something along the lines of https://github.com/prometheus/client_rust/blob/master/src/encoding/text.rs. Though...

> I think the latter would be good as we can convert the metrics to JSON. though I'm not familiar with the OpenMetrics protobuf format for now. sweat_drops I would...