Max Inden

Results 899 comments of Max Inden

> And I have noticed that prometheus-client doesn't support the OpenMetrics protobuf format due to [the issue](https://github.com/OpenObservability/OpenMetrics/issues/183). eyes That was the thing that stopped me from working on Protobuf support...

> @mxinden I would appreciate it if you could give me some advice. bow https://github.com/ackintosh/client_rust/pull/1 should fix your issue @ackintosh. Let me know if that works for you.

Please ping me once this is ready for a first review @ackintosh. Thanks for the help!

This is great news @ackintosh. Unfortunately I will be offline for a bit, thus I will likely not get to it next week :/

> I couldn't find another way, **I think `2. Download the proto file via build.rs` is good**. memo I would like the `prometheus` crate to be able to build offline,...

> Using [Buf](https://github.com/bufbuild/buf) This is an interesting suggestion. What do you think of moving it to https://github.com/OpenObservability/OpenMetrics/ as it concerns the whole project?

> For now, I've copied the .proto file manually and added into git. I don't expect any breaking changes to the `.proto` file, and thus think this is a valid...

I took another look. What do you think of https://github.com/ackintosh/client_rust/pull/6? - It does not require an associated type. - It does not force any allocations, not even on the implementation...

> Can I work on patching the issue ? @mxinden Yes, for sure. Help is very much appreciated. > In other issues I see [this](https://docs.rs/reffers/latest/reffers/) being recommended. Haven't had a...

For the record, fix is released with `v0.18.0`. https://github.com/prometheus/client_rust/pull/80