Max Inden

> The only problem I see is that the user has to interact with generated code: the enum. Good point. Agree that this adds mental complexity. That said, if documented...

> It takes away the ability for the user to control the visibility: pub, pub(super), etc Why would a user want the event to have a different visibility than the...

_Meta level: Thanks for all the input here!_ With the above arguments, agreed that there should be a way to bring your own `OutEvent`. > Define the convention on what...

> I would like to make the following suggestion. Note that I am still suggesting to additionally support the lazy case, where the `OutEvent` is generated by the procedural macro....

Replacing this pull request with https://github.com/libp2p/rust-libp2p/pull/2840 on top of the latest v0.47.0 release.

Interesting, mind printing the event that is not expected via the change below? ``` diff diff --git a/examples/file-sharing.rs b/examples/file-sharing.rs index 183bd9d6..2c069175 100644 --- a/examples/file-sharing.rs +++ b/examples/file-sharing.rs @@ -138,7 +138,7 @@...

And on which `SwarmEvent` are they panicing? When you exclude that event from `panic` do things function as expected?

`IncomingConnectionError` might be that the node is failing to connect to a private IP address? > I excluded the `IncomingConnectionError` and `Dialing` `SwarmEvent` from `panic` and the file-sharing example works...

Nodes will try to interconnect due to the Kademlia protocol, yes.

In my opinion implementations don't need to be consistent on the API level, only on the network level. In this concrete case, I don't think renaming just for the sake...