Grey
Grey
I think we should **not** increase the minimal version to 1.78 no matter what because it will leave us incompatible with the build farm which will be limited to 1.75...
I think the purpose of this PR is covered by [`InitOptions`](https://github.com/ros2-rust/ros2_rust/blob/c463201b3c17374ba3aa58d82b7c5952c9d5f680/rclrs/src/context.rs#L225-L234) which was introduced in https://github.com/ros2-rust/ros2_rust/pull/386 It should be reasonable to close this PR at this point.
We're a healthy margin past the 7-day window with no objection. How do you feel about moving forward with granting permissions, @nuclearsandwich ?
Looks like commit rights are working for both of us, thanks!
I attempted to do some debugging to figure out why nothing is being discovered for me anymore. It's not only the `ros2-rust` workspace that no longer works.., _none_ of my...
I think we'll be in a good place to merge this after #62 is merged. If I can get an approval on that PR, then I'll merge it into this...
One option could be to take advantage of the [`[package.metadata]`](https://doc.rust-lang.org/cargo/reference/manifest.html#the-metadata-table) section of `Cargo.toml`. E.g. we could have ```toml [package.metadata.colcon] rustfmt = true ``` to tell colcon that this package wants...
#396 should get us what we want. It will continue to build and test the repo using the stable channel but use nightly when checking the format.
I didn't close this yet, because we currently don't have an API that handles the transformation of the spatial inertia matrices. I don't think it would be hard to implement,...
I went ahead and created a function called math::parallelAxisTheorem(const Matrix3d&, const Vector3d&, double) which will shift a moment of inertia matrix according to the classical parallel axis theorem. I created...