Grey

Results 236 comments of Grey

I spent another day trying to work with colcon+cargo in 24.04 (Python 3.12). It seems the changes to how pip works are really problematic for colcon extensions. Here are the...

@ljburtz We've been getting a lot of help from @cottsay to improve the quality and functionality of `colcon-cargo` to a level where it can be a common extension for colcon....

As for how to install on jazzy, I personally just add the `--break-system-packages` flag since it's functionally no different than how we were doing it on earlier distros. I think...

> are you suggesting we should remove allow_undeclared_parameters flag and rclcpp::exceptions::ParameterNotDeclaredException at all? This issue report is only concerned with getting the behavior of the parameter services of the client...

> Just idea, what if we have PARAMETER_NOT_DECLARED state? I don't think it makes sense to consider "Undeclared" a different type from "Unset". Consider a node that has `allow_undeclared_parameters(true)` instead...

> that is why originally i was thinking this comes down to call list_parameter service to know declared parameters, and then call other services. > I am not really sure...

My main blocker right now for finishing up the PRs for this is [how to improve the description fetching](https://github.com/ros2/rclcpp/pull/2515#discussion_r1582854592). The essential problem is that `NodeParametersInterface::describe_parameters` has the exception-based behavior baked...

@esteve This is embarrassing since I was vocally supportive of committing the cargo lockfiles, but now I'm thinking that might have been a mistake. I'm noticing two issues in practice:...

@knmcguire Sorry to summon you into this random PR but it seems a [new CI failure has popped up for Windows](https://github.com/ros2-rust/ros2_rust/actions/runs/15956708714/job/45003949246?pr=480#step:8:41). I have a feeling this is due to [this...

@jhdcs thanks for noticing the absence of safety comments. I've added them in via [a589997](https://github.com/ros2-rust/ros2_rust/pull/480/commits/a589997b24b07b7a934b7431604f25d8e82a815a)