Marin Veršić

Results 160 issues of Marin Veršić

We use enum versioning for many of our data structures (e.g. `VersionedTransaction` or `VersionedQueryRequest`). This has to be true for structures which are going to become part of the blockchain...

question
iroha2-dev
research

After merging #4414 `with_coverage` is failing

iroha2
CI

our `Signature` is represented as: ```rs pub struct Signature { public_key: PublicKey, payload: ConstVec, } ``` but in the case that we know who's signed the message having `public_key` in...

iroha2

I think the values in metadata should be reconsidered. I'd be in favor of loosely typing it with `StringWithJson` and defer the parsing of the structure to executor as we...

question
iroha2

We should consider removing `NewParameter` ISI and only allow defining new parameters in Executor. During Executor migration old parameters will be removed and new ones can be added. The reason...

iroha2-dev

atm, user can submit a huge list of transactions and potentially use up all the memory on the peer bringing the peer down. We should add a hard-coded limit (no...

iroha2-dev
Security

Since we made `iroha2` into main branch, I think we should remove `iroha2` labels and create iroha1 labels. We will no longer tag new issues/PRs with `iroha2` label if they...

iroha2

Migrate CI to using [this](https://github.com/marketplace/actions/semantic-pull-request) action |We want to enforce the use of [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-multi-paragraph-body-and-multiple-footers). This means that we want to enforce this standard in CI for PR titles. Later...

iroha2
CI

We've long had an issue that our `client/tests/integration` are not proper black box tests. This means the have `iroha` as dependency when they shouldn't. The main goal is to remove...

iroha2-dev
Tests

Make use of the [secrecy](https://docs.rs/secrecy/latest/secrecy/) crate to prevent the secrets like `PrivateKey`(are there any other?) from being leaked accidentally by being printed in logs or serialized. `Secret` wrapper also makes...

good first issue
iroha2
Chore