iroha icon indicating copy to clipboard operation
iroha copied to clipboard

[suggestion] Move `NewParameter` into Executor

Open mversic opened this issue 1 year ago • 3 comments

We should consider removing NewParameter ISI and only allow defining new parameters in Executor. During Executor migration old parameters will be removed and new ones can be added. The reason is that having an ISI doesn't make sense for an operation that can only be executed by the blockchain admin

mversic avatar Sep 20 '23 09:09 mversic

I think that would be right

Arjentix avatar Sep 27 '23 11:09 Arjentix

What means "move NewParameter into Executor"?

As far as I understand, Executor just has access to all parameters, to the key-value storage with some data. And, Executor just "interprets" certain keys in a certain way which defines Executor's behaviour.

Is it needed for Executor to define "known" parameters in some way?

0x009922 avatar May 08 '24 08:05 0x009922

just look at how permission tokens are defined in Executor. We need to replicate that mechanism

mversic avatar May 08 '24 08:05 mversic

This instruction has been removed, now there is only SetParameter

alexstroke1 avatar Jul 31 '24 07:07 alexstroke1