iroha icon indicating copy to clipboard operation
iroha copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger

Fix `with_coverage`

Open mversic opened this issue 10 months ago • 1 comments

After merging #4414 with_coverage is failing

mversic avatar Apr 22 '24 07:04 mversic

telegram-cloud-photo-size-2-5381943039976656869-y FYI This is 6th February 2024 report using the new grcov tool from Vasiliy

AlexStroke avatar Apr 23 '24 08:04 AlexStroke

As of 2cf50c0da I2::Dev::Tests / with_coverage is failing due to -p iroha_client --test mod (client/tests/integration/). It seems to happen with the following combination:

  • nightly-2024-04-18
  • RUSTFLAGS="-C instrument-coverage"
  • -p iroha_client --test mod
    • not filtered out, because #[cfg(not(coverage))] is allowed by cargo-llvm-cov and does not work with grcov

I don't know the exact cause, but we can work around this. Just exclude the client integration tests in command without attributes

s8sato avatar May 09 '24 18:05 s8sato