Marin Veršić

Results 160 issues of Marin Veršić

If we take a look at `crypto/src/signature.rs` we can see the `SignatureOf` which is used in our `data_model` API (namely in transactions API). For instance, `ValidTransaction` is defined as: ```rs...

iroha2
Red

Check [this](https://github.com/hyperledger/iroha/pull/2557#discussion_r934203281) comment. Payload (currently a `Vec`) in structures like `PublicKey`, `PrivateKey` and `Signature` is immutable for the lifetime of the wrapping type. This means that capacity field of the...

iroha2
Red

### GIT commit hash 5ff6b67d392a0f8238d483918ea36e82d9a22937 ### Minimum working example ```rs use core::str::FromStr as _; use iroha_client::{client::Client, Configuration}; use iroha_data_model::prelude::*; fn main() -> Result

Bug
question
iroha2
QA-confirmed

Unfortunately, floating point types are non-robust in Rust. This means they should be serialized into a robust type when being sent over FFI

iroha2

### Feature request This structure in `telemetry/src/config.rs`: ```rs pub struct Configuration { /// The node's name to be seen on the telemetry #[config(serde_as_str)] pub name: Option, /// The url of...

Enhancement
question
iroha2

Example of such an enum is: ```rs pub enum Enumeration { A(u32), B(PublicKey), C, } ``` These enums (and, recursively, their variants) have to be converted into their `repr(c)` equivalent....

Enhancement
iroha2

`ffi_export` attribute can be attached on inherent impls. This is not a hard limitation, this attribute could be made to support trait impls as well. This is not a very...

iroha2
Red

I've noticed that our type checking of `EvaluatesTo` is not giving out compile errors when it is expected to do so. The following test should not compile, yet it does:...

Bug
iroha2

Check [this](https://github.com/hyperledger/iroha/pull/2557#discussion_r934223167) comment.

iroha2
Red

[derive_more::from](https://jeltef.github.io/derive_more/derive_more/from.html#enums) offers the same functionality as our `FromVariant`. Considering that we're making more and more use of the `derive_more` we should remove our custom implementation in favor of `derive_more`. `TryInto`/`TryFrom`...

good first issue
iroha2
Refactor