John Muschelli

Results 93 issues of John Muschelli

projectId should be able to pass through so `cr_project_get` isn't invoked and I believe you need to pass `timeout` to `cr_build_yaml`, but doing so just in case.

I don't know what the purpose of the failed regex created in `cr_buildtrigger_repo` so I'll just show the (what I believe) to be standard use case for using `googleCloudRunner::cr_buildtrigger` with...

When scheduling, if you're using a tar.gz (e.g. from deploy docker), this clears out that source and causes fails: https://github.com/MarkEdmondson1234/googleCloudRunner/blob/master/R/buildtriggers.R#L261

Is there use to have this in the package: ```r cr_buildtrigger_list_full = function(projectId = googleCloudRunner::cr_project_get()) { triggers = googleCloudRunner::cr_buildtrigger_list(projectId = projectId) if (NROW(triggers) == 0 || length(triggers) == 0) return(NULL)...

I didn't incorporate this into a PR since I'm not sure this is just a misunderstanding of how I should be using the scheduling, but would it be worthwhile to...

enhancement

As per https://cloud.google.com/build/docs/api/reference/rest/v1/projects.builds#Build, you may want to specify the serviceAccount to be used for the build.

enhancement

If you have `GCE_AUTH_FILE` then it should be able to extract the `project_id`, which may be less prone to errors (e.g. difference between project_name and project_id) than forcing people to...

As per https://cloud.google.com/build/docs/api/reference/rest/v1/projects.locations.triggers#BuildTrigger: build_template can be "autodetect". So if build is NULL, file is NULL, then may want to default to `autodetect`, which I think is the default with the...

enhancement

Fixes #674. I know it's heavy handed in the sense that github/bitbucket git repos are going full depth, but otherwise you can't use SSH with `install_git` to specific SHAs. The...

This passes the `git` argument all the way through on the `install_remotes` so that if you have any remote dependencies with a prefix of `git::` and you set `git =...