Aurélien Mino

Results 86 comments of Aurélien Mino

> In any case, this recipe is meant to be enabled and reviewed manually by the users. I don't see how it could cause harm This is one use case,...

These checks often take a lot of time, so running on every PR (change) is probably not a good idea.

> > > Issue confirmed! > @murdos Tested with generator v6.10.4 and this update is needed I agree it's needed. But the problem is that the source of version 3.0.1...

There's already a PR for that (https://github.com/hipster-labs/generator-jhipster-entity-audit/pull/147), but I'm not in favor of merging it until we know where this new version of ng-diff-match-patch comes from (https://github.com/elliotforbes/ng-diff-match-patch/issues/39)

This feature will require the merge and release of this fix to data-spring-jpa: https://github.com/micronaut-projects/micronaut-data/pull/773 **Update:** released with micronaut-data 2.1.0, dependencies update will come with micronaut 2.1.2

> > > For the failing gradle builds, can you check it uses `micronautVersion`? It seems it tries to use the old property `micronaut_version` Good catch, thanks! FWI this PR...

I started work on the subject a few days ago (mainly thinking about solutions). My plan is to try to use micronaut support for Spring Data JPA specification.

IMO starting with micronaut-spring-data-jpa is a good enough solution, until micronaut-data supports dynamic query criteria: https://github.com/micronaut-projects/micronaut-data/issues/89

> > > Have you encountered "org.hibernate.HibernateException: Could not obtain transaction-synchronized Session for current thread" with this implementation? This is where I've stopped working on this. Yes. Adding micronaut-spring dependency...