generator-jhipster-entity-audit icon indicating copy to clipboard operation
generator-jhipster-entity-audit copied to clipboard

fix version of ng-diff-match-patch (2.0.6 to 3.0.1) for angular 9

Open jbacquet opened this issue 5 years ago • 4 comments

ng-diff-match-patch v.2.0.6 is not compatible with angular 9 Ivy and needs to be upgraded to latest version 3.0.1

jbacquet avatar Mar 17 '20 17:03 jbacquet

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jbacquet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 21 '20 10:04 CLAassistant

Issue confirmed! @murdos Tested with generator v6.10.4 and this update is needed

DanielFran avatar Oct 25 '20 15:10 DanielFran

Issue confirmed! @murdos Tested with generator v6.10.4 and this update is needed

I agree it's needed. But the problem is that the source of version 3.0.1 are not public and thus we don't know what it contains. It might be compromised, that I'd rather not do the update.

murdos avatar Oct 25 '20 21:10 murdos

@murdos The sources are available: https://github.com/elliotforbes/ng-diff-match-patch/compare/2.0.6...master

Current version 3.0.1 contains probably commits until Jul 03, 2018

Without this update, module did not work

DanielFran avatar Oct 25 '20 21:10 DanielFran