Not compatible with angular 9+

[edy-ap]

This likely means that the library (ng-diff-match-patch) which declares DiffMatchPatchModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

[bukohub]

I have the same error. Iuk.

[bukohub]

Men, I found the solution this problema. You need update ng-diff-match-patch to last version.

[deepu105]

Would you be willing to a PR?

On Tue, 30 Jun 2020, 1:52 am bukohub, [email protected] wrote:

Men, I found the solution this problema. You need update ng-diff-match-patch to last version.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hipster-labs/generator-jhipster-entity-audit/issues/148#issuecomment-651428658, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKF5BTJZZYPZH7G2A6ZDRZESNNANCNFSM4MLCQU5A .

[murdos]

There's already a PR for that (https://github.com/hipster-labs/generator-jhipster-entity-audit/pull/147), but I'm not in favor of merging it until we know where this new version of ng-diff-match-patch comes from (https://github.com/elliotforbes/ng-diff-match-patch/issues/39)

[deepu105]

Oh I didn't realize that we are changing lib. Ok I'll leave it to you then

On Tue, 30 Jun 2020, 1:02 pm Aurélien Mino, [email protected] wrote:

There's already a PR for that (#147 https://github.com/hipster-labs/generator-jhipster-entity-audit/pull/147), but I'm not in favor of merging it until we know where this new version of ng-diff-match-patch comes from (elliotforbes/ng-diff-match-patch#39 https://github.com/elliotforbes/ng-diff-match-patch/issues/39)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hipster-labs/generator-jhipster-entity-audit/issues/148#issuecomment-651722534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKF4UBCQP6DYGUVPNJCDRZHA5XANCNFSM4MLCQU5A .

[bukohub]

@murdos, @deepu105. Actually, there are some problems with generator-jhipster-entity-audit in angular 9.

1. ng-diff-match-patch, (I solved that solution with update version, but @murdos has reason).
2. admin-routing.module.ts, generates two commas in his route.
3. entity-audit-modal.component.html, generates a <pre class="code" id="resultChanges" diff [left]="left" [right]="right">, that generates issue, in tags left and right (angular version problem).

In all the time using entity-audit, this was my problems.

[bukohub]

This generator is incredible (really). I would like contribute it, but I don't know how to do a PR.

[vaibhavg12]

@bukohub how did you resolve no 3?

@murdos, @deepu105. Actually, there are some problems with generator-jhipster-entity-audit in angular 9.

1. ng-diff-match-patch, (I solved that solution with update version, but @murdos  has reason).

2. admin-routing.module.ts, generates two commas in his route.

3. entity-audit-modal.component.html, generates a  <pre class="code" id="resultChanges" diff [left]="left" [right]="right">, that generates issue, in tags left and right (angular version problem).

In all the time using entity-audit, this was my problems.

[dhavalmshah]

@bukohub how did you resolve no 3?

@murdos, @deepu105. Actually, there are some problems with generator-jhipster-entity-audit in angular 9.

1. ng-diff-match-patch, (I solved that solution with update version, but @murdos  has reason).

2. admin-routing.module.ts, generates two commas in his route.

3. entity-audit-modal.component.html, generates a  <pre class="code" id="resultChanges" diff [left]="left" [right]="right">, that generates issue, in tags left and right (angular version problem).

In all the time using entity-audit, this was my problems.

Probably there are much better ways, I changed the entity-audit-modal.component.ts to make left and right as regular strings:

export class EntityAuditModalComponent {
  action?: string;
  left: string;
  right: string;

  constructor(private service: EntityAuditService, public activeModal: NgbActiveModal) {this.left=""; this.right="";}