ali

Results 12 comments of ali

@kirtimanmishrazipstack Please Fix Sonar issue before Merge

> @muhammad-ali-e LGTM overall. > > However, I suggest to rename new env var to `DB_SCHEMA`. Then use this env value if set, otherwise use default (from hereon we can...

> @muhammad-ali-e LGTM overall. > > We need to either rename the env var to `DB_SCHEMA` if we are going to continue having it from hereon or we need to...

> @muhammad-ali-e Observed below error in `execution-consumer` though: > > ``` > [2024-08-16 05:35:12,761: ERROR/MainProcess] Received unregistered task of type 'workflow_manager.workflow.execution_log_utils.consume_log_history'. > The message has been ignored and discarded. >...

API already addressed https://github.com/Zipstack/unstract/pull/630/ .

Delta changes (That came after this PR raised) will be addressed another PR .

> @muhammad-ali-e : We need to include 202 as well right? If the post call exceeds the timeout, then user needs to get the response in get call. so we...

> @muhammad-ali-e, If a API key is provided but in Invalid UUID format, then I am getting 500, have you handled this scenario? We should throw a 400 error also...

@chandrasekharan-zipstack It might not be needed IF we rollout V2