unstract icon indicating copy to clipboard operation
unstract copied to clipboard

Added README file along with the API Deployment code

Open muhammad-ali-e opened this issue 1 year ago • 5 comments

What

  • Added README file for API Deployemnt

Why

  • Requirements

How

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

muhammad-ali-e avatar Sep 13 '24 04:09 muhammad-ali-e

@muhammad-ali-e, If a API key is provided but in Invalid UUID format, then I am getting 500, have you handled this scenario? We should throw a 400 error also here. Same for GET request If execution_id is provided in invalid UUID format, then I am getting 500 error

nagesh-zip avatar Sep 13 '24 05:09 nagesh-zip

@muhammad-ali-e : We need to include 202 as well right? If the post call exceeds the timeout, then user needs to get the response in get call. so we need a 202 here

@VikashPratheepan Here We addressed only the documenattion for existing API Deployement beahaviour. No code changes

muhammad-ali-e avatar Sep 13 '24 12:09 muhammad-ali-e

@muhammad-ali-e, If a API key is provided but in Invalid UUID format, then I am getting 500, have you handled this scenario? We should throw a 400 error also here. Same for GET request If execution_id is provided in invalid UUID format, then I am getting 500 error

@nagesh-zip Here We addressed only the documenattion for existing API Deployement beahaviour. No code changes

muhammad-ali-e avatar Sep 13 '24 12:09 muhammad-ali-e

@muhammad-ali-e LGTM overall.

However, can we please move this README to docs/backend/api in the root level? Let's have all the docs there.

hari-kuriakose avatar Sep 18 '24 04:09 hari-kuriakose

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

github-actions[bot] avatar Sep 18 '24 04:09 github-actions[bot]

@muhammad-ali-e closing this since this is going to be part of the docs repo.

ritwik-g avatar Sep 18 '24 04:09 ritwik-g