unstract icon indicating copy to clipboard operation
unstract copied to clipboard

delta changes and enhancements in platform and prompt services

Open muhammad-ali-e opened this issue 1 year ago • 5 comments

What

  • Implemented enhancements and new changes from V1 to V2 for platform and prompt services.
  • implement new shema for v2
  • Changes on token usage method
  • Changes on Authentication methods

Why

  • To improve the performance and functionality of platform and prompt services.

How

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No, All are uunder featureflag

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

muhammad-ali-e avatar Jul 30 '24 10:07 muhammad-ali-e

@muhammad-ali-e LGTM overall.

However, I suggest to rename new env var to DB_SCHEMA. Then use this env value if set, otherwise use default (from hereon we can keep a default schema name for multi-tenancy with single schema).

@hari-kuriakose I think it should confuce the OSS users if we use DB_SCHEMA. My opinion is we can change the env variable to DB_SCHEMA once we completly moved to v2.

muhammad-ali-e avatar Aug 13 '24 04:08 muhammad-ali-e

@muhammad-ali-e LGTM overall. However, I suggest to rename new env var to DB_SCHEMA. Then use this env value if set, otherwise use default (from hereon we can keep a default schema name for multi-tenancy with single schema).

@hari-kuriakose I think it should confuce the OSS users if we use DB_SCHEMA. My opinion is we can change the env variable to DB_SCHEMA once we completly moved to v2.

@muhammad-ali-e If we are going to continue keeping this env var, then DB_SCHEMA would be better as users could supply any value as desired and not locked to v2 specifically. Hence mentioned so.

However if this env var is to be used only temporarily for v2 migration, then ok.

hari-kuriakose avatar Aug 20 '24 11:08 hari-kuriakose

@muhammad-ali-e LGTM overall.

We need to either rename the env var to DB_SCHEMA if we are going to continue having it from hereon or we need to remove the env var altogether after v2 migration.

updated

muhammad-ali-e avatar Sep 24 '24 04:09 muhammad-ali-e

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

github-actions[bot] avatar Sep 24 '24 12:09 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Sep 24 '24 12:09 sonarqubecloud[bot]

Duplication will be taken care of when we remove v1 later.

hari-kuriakose avatar Sep 24 '24 12:09 hari-kuriakose