Matthew Brown

No — I think if the intent of the refactoring is sound, people generally “get it”

Mind PRing this?

In PHP 8.1 there are now deprecation notices when extending a class without specifying its types. Running ``` class Foo implements Iterator { public function current() { return 'foo'; }...

This is ultimately an issue with the `tus-php` package required by `vimeo/vimeo-api`

Oh definitely happy to have it become a psalm-specific plugin. Also there are already a lot of annotations in newer doctrine code (e.g. collections) that make the plugin slightly less...

I opened a duplicate issue in Psalm's repo: https://github.com/vimeo/psalm/issues/8482 Hack solves this with the solution I give there, but I'm hesitant to copy that implementation because the type hole is...

The edge-case I was talking about is the false-negative I mention in the linked issue. _This_ issue also mentions a number of false-positives in PHPStan (some of which also appear...

I think PHP-CS-Fixer should follow the fairly-widely-adopted community standard. But I also think it's a shame that `@var` was chosen for inline things – something like ```php function returnsString(EncoderInterface $encoder):...

Yeah, that's why I think `/** @infer string */` should be used instead as it doesn't muddy the waters (I'm happy to add support for this in an upcoming version...

This also converts property names, which may not be desired. To avoid that I changed the `applyFix` method locally: ```php /** * {@inheritdoc} */ protected function applyFix(\SplFileInfo $file, Tokens $tokens)...