Matthew Brown comments

Results 64 comments of


                                            Matthew Brown

psalm should detect syntax errors in regex-patterns

OTOH I imagine these errors are relatively rare, and it might parsing every regex might slow Psalm down a little

Demo: hackana for finding executable code

This looks good! You might want to look at the test file config to only generate for production files

Allow callable():string to be accepted wherever callable():void is:

if you think about it, this is different ;)

Allow callable():string to be accepted wherever callable():void is:

I agree that it looks similar, but this don't think this violates LSP in the way overriding a `void`-returning function does.

Allow callable():string to be accepted wherever callable():void is:

I believe TypeScript's rules allow `void` return to be overridden because of this (quite common) use case (see https://github.com/Microsoft/TypeScript/issues/4544). If I'm to guess, `void` return overrides are a side-effect.

closure parameter are analysed without the function context ( generics ) when used with userland functions.

Psalm has some special behaviour for `array_map` because it knows the type of the first array is unpacked into the argument for the second. Imagine that the params are flipped:...

closure parameter are analysed without the function context ( generics ) when used with userland functions.

I stand very corrected!

closure parameter are analysed without the function context ( generics ) when used with userland functions.

> can this special behavior be replicated for other functions using a plugin No, but once I figure out how Hack is doing it this will work in Psalm. Given...

closure parameter are analysed without the function context ( generics ) when used with userland functions.

Equivalent PHP: https://psalm.dev/r/2767b16320

Mistaken error 'If condition is always true.' with goto

http://www.cs.utexas.edu/users/EWD/ewd02xx/EWD215.PDF