Matthew Brown comments

Results 64 comments of


                                            Matthew Brown

Handle in dsn optional dbname delimiter

Thanks! Mind fixing the typo?

Handle in dsn optional dbname delimiter

You added an `i` — `Privilegies` vs `Privileges`

Support for BOOLEAN column type

Mind fixing the Psalm errors?

Look into documenting hover delay

Dunno if this is still an issue. Psalm [precomputes all possible hover responses](https://github.com/vimeo/psalm/blob/b982090e10b7c860127ee580bd08775049438187/src/Psalm/Internal/Codebase/Analyzer.php#L598-L618) when analysing in server mode, so fetching is done quickly. It looks like your lookup is much...

Look into documenting hover delay

Ah, now I see that VS Code doesn't consider a file opened unless you're editing it, so you may have un-analysed files that you're hovering over.

[Generics] Recursive / self-referencing template type variable

FYI recursive types are _very_ hard to reason about (though support for a JSON recursive type would probably come in handy)

[Generics] Recursive / self-referencing template type variable

> so the real answer is: NO FYI this comes across as extremely douchey

impelement MAKETIME and TIMESTAMP function parser

Hey! Please remove the formatting-related changes in the files you touched. That’ll make the PR easier to review. The issue tracker is closed because this isn’t an actively-supported project. It’s...

Fix OSS build

Thanks for this — at Slack we are also very interested in this PR, which contains a few changes we've already independently applied to our local patch (which is at...

psalm should detect syntax errors in regex-patterns

@weirdan I guess because regex is a core language feature, it's not necessarily something that should live in a plugin – for reference PHPStan uses a `Nette` library for regex...