Michael Tsitrin

Results 79 issues of Michael Tsitrin

currently, `x/eIBC` supports: this filters by the **RollappPacket** state. for eIBC, the more usable query would be to query for `fullfilled/unfullfilled` demanOrders

currently both `x/eibc` and `x/delyaedack` emit event upon store write. This causes for redundant events, due to internal logic, when packet's status changes. The events should correlate with "logical" events...

e.g `DymintPubKey` in the `MsgCreateRollapp` should be mandatory. w/o `nullable = false`, it can be nil and therefor always checked for in the code. mandatory complex fields, should be set...

t:refactor

example: this could all be shortened by a generic dedupe function, and https://pkg.go.dev/slices#ContainsFunc or https://pkg.go.dev/slices#IndexFunc psuedo: ``` if len(permissioned) != len(deduped(permissioned)) { ..} if i := slices.indexFunc(permissioned, func(x){ _, err...

currently the proposal cli command accepts only arguments. ` submit-fraud-proposal ` we should be able to read the proposal from json file as well **also** we should accept empty channelID...

Almost all PRs have this check fails Need to tweak to have meaningful impact

t:ci

currently, `BlockHeightToFinalizationQueue` prefixed with `creation_height` and holds unsorted array of `stateIdx` The queue should be prefixed by `height/rollappId`, so all the pending of a specific rollapp can be queried easily...

c:rollapp

Currently the roller installed in `/usr/local/bin` while the makefile's `make install` installs to GOBIN path It causes that in case roller was installed using the `install` script, running `make install`...