mstr2
mstr2
I've created a small [playground app](https://github.com/mstr2/jfx-layout-sample) that shows a few scenarios in which a baseline-aligned layout now works as expected. Here's a screenshot of the current behavior on the left...
For what it's worth, I agree that updating the bounds or synchronizing peers shouldn't trigger a new layout cycle. Unfortunately, test coverage is not good for the `javafx.scene.text` classes, so...
> The simple null check helps in this case. But sometimes I see the exception, posted by @Maran23 . So the root cause is probably not fixed - but the...
Here's another proposal: 1. Expose `pivotX` (default: 0.5), `pivotY` (default: 0.5) and `pivotZ` (default: 0.5) as three separate doubles. 2. Add `relativePivot` (default: true), which controls whether the pivot coordinates...
> This would be great for creating customized themes with different window decorations if that were to be supported some time down the line with this feature. > > Is...
I don't understand how the original code, as well as the proposed solution, can work at all. Let's take @kleopatra's example: ```java selectionModel.selectIndices(0, 2, 3); // ---> expected: { [0,...
It's true that `Parent.getChildren()` must not return `null`, and that we shouldn't add null checks to protect against bugs. However, in this specific instance, `Node.setTreeVisible` is called from the constructor...
> I haven't looked at the code yet, but in general it's not considered a good idea to expose an object before it's instantiated. Not sure if we have a...
Why are the new listener imlementations called `BaseChangeListener` and `BaseInvalidationListener`, i.e. why the _Base_? Also, if you're going to the trouble of refactoring the existing listener implementation, have you considered...
Fundamentally, the problem does not arise from bindings, but from the fact that `ListPropertyBase` adds a `ListChangeListener` to its wrapped `ObservableList`. Since the added `ListChangeListener` is a capturing lambda, the...