mstr2
mstr2
> @mstr2 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a...
@Maran23 You previously reviewed and tested the proposed changes. If everything looks good to you, can you approve this PR?
Thank you very much @hjohn for your extensive review. Before addressing your comments, I'd like to get some clarification (ideally also from @kevinrushforth), because I am a bit confused by...
I've resolved some merge conflicts with the latest `master` branch. @arapte can you re-review?
> Can this not be done in a way that doesn't require this `underInitialization` flag? That's a good idea, and a also a good observation that the constructor only really...
I've extended the tests to check for the other direction as well. @hjohn @nlisker can you re-review?
I've added the suggested optimization for `ModifiableObservableListBase.addAll`, as well as `ObservableSequentialListWrapper.addAll`. Additionally, there are more tests to ensure adherence of the optimized methods to the collection contracts (NPE and IOOBE...
I've added comments in all places where implicit null checks are important to satisfy the collection contract. In addition to that, I've also re-organized the tests using nested test classes,...