mstr2
mstr2
`ListenerManager` is an obvious improvement, as it fixes incorrect behavior and allows listeners to veto changes. However, the behavior of `ListenerManager` is also an implementation detail and not documented anywhere....
I agree with John that a layout algorithm that uses incremental calculations will always be flawed in principle. The correct approach is to store the initial configuration, and then for...
> I respectfully disagree, @mstr2 . > > This fix is not an interim solution - unlike any theoretical considerations of "flawed approach", in practice this code does work as...
> What about SWT ? It looks like SWT also supports dark mode since version 4.12 [1][2]. > > [1] : https://eclipse.dev/eclipse/news/4.12/platform_isv.php#dark-theme-mac [2] : https://bugs.eclipse.org/bugs/show_bug.cgi?id=540357 I haven’t tested this in...
I've tested `AAA BBB CCC` in Chrome, and the text is rendered pretty much exactly as your "before" version: Center:  Right:  Here's the HTML: ```html AAA BBB CCC...
> > I've tested `AAA BBB CCC` in Chrome, and the text is rendered pretty much exactly as your "before" version: > > For the current rendering that JavaFX does,...
I run manual tests on the command line like so: ``` java --module-path=$env:JFX_SDK --add-modules=javafx.controls ./tests/manual/events/PlatformPreferencesChangedTest.java ``` This doesn't work with the new utility class, since it is outside of the...
> > Short of using a build system, how would I run a manual test with this new class? > > I am running from within Eclipse. Here is the...
@jperedadnr Maybe you could test this PR with the pen digitizer that you used for #394 to ensure that this change doesn't introduce yet another regression.