Markus Stange

Results 247 comments of Markus Stange
trafficstars

Thank you! It'll probably be a while before I'll have time to pursue this, but now I know where to start looking.

I've made some progress on this now. Code is here: https://github.com/mstange/macho-stubs/blob/6dbb225e43002afe97a539682bbba731029c0fc9/src/main.rs#L140-L298 This gives me the addresses in the `__DATA` segment for the pointers that are updated. But it doesn't give...

If new parsing code for this format were to be written, I'd prefer to have it in a separate crate, similar to [`macho-unwind-info`](https://github.com/mstange/macho-unwind-info). Then I'd be able to use it...

This spec seems to have changed quite a bit since the implementation in Gecko. It no longer mentions scrolling ancestors, it exclusively talks about containing blocks now. I agree that...

I'd also be happy to co-maintain this crate.

I was able to get a `"corrupt_symbols": true` in the `"modules"` section of the JSON. But in the `"threads"` / `"frames"` part of the JSON, the relevant frames had `"missing_symbols":...

Ah, so this explains why the try crash report from [this bugzilla comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1779630#c1) displayed XUL as missing symbols: The symbols were there, but they were using the inline-ful sym format...

Here's a [deploy preview link](https://deploy-preview-4193--perf-html.netlify.app/public/megpap29sb3kf1vwvgtad8rte93cfcgb8cwv4pr/flame-graph/?globalTrackOrder=0wc&hiddenGlobalTracks=0wac&hiddenLocalTracksByPid=7400-0~16944-0~16780-0~11048-0~8936-0~15808-0~6504-0~14176-0~17676-0~17048-0~15092-0~2012-0~5468-0whjwxe&thread=c&transforms=f-combined-0wb78cd&v=7) with a Firefox profile to which I manually added `"doesNotUseFrameImplementation":true`.

This is pretty cool! With the Firefox profile I noticed some confusing output where categories were seemingly duplicated, e.g. there are two rows for "Graphics". I think the first row...

In the deploy preview I noticed that, on mouseup after resize dragging, I often also trigger the column sort when I don't mean to. Also, resizing is canceled when the...