Markus Stange

Very nice! It seems to work correctly. I have a few comments, about the naming and about the implementation. First off, using the word "method" in "Method Table" is a...

I have thought about this more and have come to the conclusion that my advice about the cache was probably misguided. Computing a set per stack upfront is not necessarily...

> It supports all the amenities of the CallTree view like the side bar or highlighting the samples in the timeline. Oh, I forgot to comment on this. One thing...

I hope to look at this later this week. While testing this, I found a profile which shows sluggish preview selection handling: https://deploy-preview-4227--perf-html.netlify.app/public/kva8z3a82gvp50t0xw49re353y90atzs6bka2dr/function-table/?globalTrackOrder=0&hiddenLocalTracksByPid=14432-01&localTrackOrderByPid=14432-01&thread=0&v=7 Maybe this example can help us optimize...

Still haven't found time to look at this in detail, hoping for this week. In the new deploy preview, dragging a selection now works very fast, nice! I noticed that...

> > It looks like graph highlighting is working nicely now, though I don't really understand how it can work - how did you address this case I mentioned in...

> One bug I found is that double-clicking a function will not scroll the source view to the clicked function. For example, opening the source view on `js::GCMarker::traverse(JSString*)` displays the...

I still need to read the "summary" code. I'm getting there, slowly. I have one more general request: Please use JavaScript arrays for the new arrays you're adding, not Typed...

I have read the summary cache tree code now. Let me try to summarize what it does: It reduces the time taken to compute function timings for a sub-range of...

> > It's a neat idea, and I hadn't thought of it before. But I think it's a bit complicated, and it also has a certain memory cost. > >...