Markus Stange

Results 247 comments of Markus Stange
trafficstars

So I wonder if all solutions here require the addition of jank markers to Java threads. Is it even possible to get event loop information for these threads?

True. But since the original data was sampling based, I think it would be preferable to emit a profile that's a closer representation of that original truth. So you'd want...

This isn't blocking me at the moment so I'm probably not going to work on it. Feel free to take it over. Oh, and it probably should have a test......

I don't have a strong opinion. But I think a tri-state selector in the Call Tree tab might work: ``` [Top-down | Bottom-up | Butterfly] ``` (actual names to be...

Here's an example: (edit: I've also added this to the issue description now) ``` Normal: total self 19 - (root) 19 - RunLoop 10 - ProcessCircles 10 2 ProcessElement 8...

Yes, I think that would be a good first step. You could even drop the side panels for now and just have the top functions list. But we do need...

Here's a profile where a top functions view would work very well: https://share.firefox.dev/3rM8fEp Some modules get loaded repeatedly from different stacks. For example, `aria-query/lib/index.js` shows up in different stacks: https://share.firefox.dev/3rLw530...

Hmm, maybe it's the use of IndexedDB. But even with cookies disabled I can't reproduce this. I haven't tried very hard though. @julienw Can you reproduce this?

When triggering symbolication from the re-symbolicate button, we could, prior to sending the JSON request to the symbolication API, do some `HEAD` requests for each of the cached libraries, to...

Oh, I just saw that it actually does display the sample count in a table further down in the tooltip. This makes this problem less severe. Still, I think presenting...