Manu Sridharan

Sorry for not circling back to this PR for a bit. Fixing it up requires a bit of thought and I haven't had time. I do plan to circle back...

I'm not a Maven expert. @kageiit any ideas or thoughts on who would know this? Basically need a way to tweak the "main" javac args but not those for test...

Thanks @kageiit. We actually need the `compilerArgs` parameter from more recent compiler plugin versions to pass strings as arguments: https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#compilerArgs https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html#compilerArgs Our [Maven example](https://github.com/uber/NullAway/wiki/Configuration#maven) currently sets `compilerArgs` in the global...

@cbruegg yes that will work if you are using the default filesystem layout. And it could be adapted if you're doing something else. I still suspect there is some configuration...

You're right that NullAway doesn't currently model `System.exit()` correctly. I think using it outside of a main driver class is regarded as an anti-pattern since, as you point out, there...

Could you edit your comment above and properly indent the `pom.xml`? It's very hard to read as is. Thanks!

Thanks. FWIW, your config doesn't look consistent with what was recommended for EP 2.3.4: https://github.com/google/error-prone/blob/v2.3.4/examples/maven/pom.xml Their config runs Error Prone as a javac plugin using `-Xplugin:ErrorProne`. Just FYI, if it's...

I just realized that your Maven `pom.xml` is probably based on [our example](https://github.com/uber/NullAway/wiki/Configuration#maven) which is out of date 🤦‍♂️ I will fix that now! (EDIT: it's updated.)

@Supernova2014201970 I am unclear whether you want to treat `MyClass` as excluded, unannotated, or both. I'm also unclear if this issue has anything to do with Maven (doesn't seem like...

> I think returns should be assumed also `@Nullable`, not `@NonNull`. The idea is to be maximally permissive with unannotated classes, to avoid excessive false positives in code we are...