Manu Sridharan
Manu Sridharan
Small update: disabling handling of zero-length arrays was added in https://github.com/wala/WALA/commit/d22ee36b09b8c0b473a95c31c7f25e3a96a7538c and is related to using WALA with Averroes. In normal usage I would not recommend setting that to false.
I could see `handleStaticInit` having an impact. `handleZeroLengthArray` should have nothing to do with it.
@amordahl any update on this issue? Do you still think there may be a WALA bug here?
FYI @cushon. I think this is a pretty safe bug fix
Was there some issue with merging this PR? I see commits related to it but nothing yet on the main branch.
I see there is already a commit for this issue; thanks for looking into it so quickly! Can we close out the issue as fixed, then? I can test once...
FWIW a possible difference between this and previous test cases is that the code being compiled uses `@NullMarked` and `@NullUnmarked` on methods: https://github.com/uber/NullAway/blob/e1ea7f62e8c82fe578e1c18446827849dad76c39/test-java-lib/src/main/java/com/example/jspecify/unannotatedpackage/Methods.java
After further thought I realized we probably want to have NullAway support JDK 8 for some time longer, to support more open-source projects that haven't updated. So having JSpecify support...
Thanks so much for investigating, @cpovirk. I have one question. Based on the stack trace and error message, I don't think this crash in JDK 8 javac is intended behavior....
I will report this upstream and then report back. Let's hope for a positive response :-)