Sean Gilligan

Results 469 comments of Sean Gilligan
trafficstars

ee2b20c5eccf038d98be27e80fdda8eb519da51c fixes the split package problem. Note: There are still some conflicts between shadow plugin and module plugin and between picocli and application plugin run task.

Since Commons CLI is still supporting Java 7, it might make more sense to add an "Automatic-module-name" header to the JAR as suggested by https://issues.apache.org/jira/browse/CLI-299 and implemented in PR #35...

Now that `pom.xml` has been upgraded this PR consists solely of creating an empty file named `profile.module-name `.

I've been using a tempFile, but that is problematic for several reasons. When do you think you'll have something ready to test?

Thanks! That looks like it will work for me. I'd like to see a stream-based solution, too -- but I'm not yet in a position to try that out. I'm...

That makes sense. I don't know if or how much you care about not loading the whole file into memory...

Yeah, that sounds like the most flexible approach...

Note that you can call arbitrary RPC methods as follows: client.send("addnode", "209.90.224.4:8333", "add"); client.send("getaddednodeinfo", true); If the parameters are types that are already supported and you don't need the result...

@magg I made a quick commit to master 8967393f19a8226c29b40b30d3817c79d1ab17cd (and a second one that fixes an omission in my part 537ebc3658168760cbedaaba32890c79d84effe8) I didn't add any tests, but I'm pretty sure...