Sean Gilligan

Results 506 comments of Sean Gilligan

> Seems like logback-android needs to adapted to some change of slf4j 2.0. It might be that your Android build is filtering out a resource in `META-INF/services` that defines a...

> If the internals of the class still work with NetworkParams, I think we don't win much here. We are trying to convert the example apps to using `Network` to...

This is rebased and ready-to-review. I don't know if the deserialization is correct, though. I'm hoping someone can review it and tell me.

I'm just suggesting a desktop GUI, which would be especially cool if you're able to get things working with a local node.

I don't think **bitcoinj** currently supports creating a taproot address from a key. As of [v0.16](https://bitcoinj.org/release-notes#version-016) it supports sending to taproot addresses, but probably those need to be created from...

> I assume you're doing this so wallettemplate has a version? Without this change `wallettemplate` gets a version of 1.0. I figured we wanted all modules to have the same...

> I thought by default Gradle projects don't have a version at all? And the Gradle documentation says so too: The version defaults to unspecified. That's not the behavior I...

In any event, Gradle provides a lot of flexibility in managing a global version and/or versions for each subproject. What are you concerns? How would you like to manage versions...

> Wallet-template for me is also an example I'm trying to make it into more of a re-usable library, which is the end-goal of the changes I've been submitting lately...