Sean Gilligan

Results 430 comments of Sean Gilligan

For deserialize there are static methods: https://bitcoinj.org/javadoc/0.16.2/org/bitcoinj/crypto/DeterministicKey.html#deserialize(org.bitcoinj.core.NetworkParameters,byte%5B%5D) For serialize there are `getPrivKeyBytes` and `getSecretBytes` Note that in 0.17 we will be migrating from `NetworkParameters` to the new `Network` enum and...

At present, it seems to me, you have 3 options: 1. Continue using the deprecated method. 2. Serialize to a Base58 string. 3. Write your own serialization with the private...

> I'm fine with throwing an exception. Adding inputs with unknown value to the fee seems way too scary. And as you said, with segwit/taproot we can't continue the behaviour...

> might want to throw a checked exception in this case. The existing exceptions (e.g. `DustySendRequested`, `MultipleOpReturnRequested`) thrown by `completeTx` extend `o.b.w.Wallet.CompletionException` which extends `RuntimeException`, I take back my suggestion...

> I would have thrown a new subclass of `CompletionException` but that exception is a `RuntimeException`. We both were typing at the same time. I agree it should be a...

> I think we should avoid using `In/Out.getIndex()`. It needs the parent, which I'm trying to migrate away from currently. Good point. I rebased given that PR #3018 was merged....

Converting to DRAFT as a reminder to explore using streams or other alternative to `for(;;)`

https://github.com/bitcoinj/bitcoinj/pull/2466 implements the deprecation.

> The interface has been deprecated and we'll remove it in the 0.18 cycle. I'm setting the milestone as a reminder. I changed the title to reflect that it has...