Sean Gilligan
Sean Gilligan
This should be rebased and completed.
> Just for reference, my code is: > > ``` > Map a = new HashMap(); > for (TransactionOutput output : wallet.calculateAllSpendCandidates()) { > Address addr = output.getScriptPubKey().getToAddress(params); > Set...
This is rebased and updated a bit.
> I aggregate the UTXO values by address, and sort the resulting table by values (highest first). > > Do you think this would be a good default behaviour, or...
> Modifies the `SegwitAddress` class to directly store the witness program and witness version, rather than their combined, Base32 encoded version. Technically, the combined version is only partially Base32-encoded, with...
I think this PR contains at least one good idea. But I propose we first move `byte[] bytes` to a format that maintains the `witnessVersion` prefix followed by the standard...
This PR has been effectively implemented by two other PRs in a series of related refactorings, see: * https://github.com/bitcoinj/bitcoinj/pull/2744 * https://github.com/bitcoinj/bitcoinj/pull/2745 Thanks @matthewleon for this suggestion!
@schildbach This can be closed. (See my previous comment.)
This needs to be rebased and/or rethought in light of our recent refactoring and included in release 0.17. See also: https://github.com/bitcoinj/bitcoinj/pull/2969#issuecomment-1493165840
I've created a handful of PRs that are meant to provide up-to-date implementations of much of this PR and to work towards streams/functional-style implementations of other CoinSelectors: * https://github.com/bitcoinj/bitcoinj/pull/3223 *...