Mustafa Said Ağca
Mustafa Said Ağca
Hi @bendrissou Updating the line comment as follows resolves this issue but I'm not sure if this change complies with the spec. ```antlr LINE_COMMENT : '--' ( ~[\r\n\u005b\u0085\u2028\u2029] SingleLineInputCharacter* )?...
From the [spec](https://www.lua.org/manual/5.4/manual.html#3.1): *A comment starts with a double hyphen (--) anywhere outside a string. If the text immediately after -- is not an opening long bracket, the comment is...
@bendrissou I'm not sure what you mean by line comments starting with `[`, can you give an example?
@bendrissou The paragraph I quoted earlier from the spec suggests that `--[aaa` shall be treated as a long comment. In this case, you could prepend an additional hyphen to make...
Hi @thechickenundertheroad, PLCL (`+:`) defined in the lexer is for range expressions. It would make no sense to produce two distinct tokens (`+` and `:`) for this operator. There is...
Hi @klcheungaj I've merged ANSI and non-ANSI style header declarations into one rule because the original syntax was ambiguous. I might have made a mistake while doing so. Can you...
@klcheungaj The last alternative of `ansi_port_declaration` covers the explicit port, so I got rid of the second alternative of `port`. ```ebnf port ::= [ port_expression ] | . port_identifier (...
@klcheungaj Yes, anything that can match any alternative of `ansi_port_declaration` is omitted in `port_expression`. I minimized the coverage of the rule `port` because ANSI style port declaration is more commonly...
Hi @quantrpeter I think the grammar is in a good state. Of course it can be further optimized and improved but it works fine enough. As a user of it...
> when do we need to use VerilogPreParser? It parses preprocessor directives. You need to handle them first before beginning the actual parse. If you're sure that the input text...