Mustafa Said Ağca
Mustafa Said Ağca
@quantrpeter Tokens belonging to preprocessor directives are on the [DIRECTIVES](https://github.com/antlr/grammars-v4/blob/master/verilog/verilog/VerilogLexer.g4#L26) channel. You have to pass the correct channel ID (3) to [CommonTokenStream](https://www.antlr.org/api/Java/org/antlr/v4/runtime/CommonTokenStream.html). And you may have to call the [fill()](https://www.antlr.org/api/Java/org/antlr/v4/runtime/BufferedTokenStream.html#fill())...
@quantrpeter IEEE 1364-2005 spec does not explicitly state that `ifdef_group_of_lines` must begin on a new line; so, I didn't require it in the grammar. Anything that comes after `INCLUDE_RSTN` (`text_macro_identifier`)...
@quantrpeter If you mean this part: `asdasd asda s da`, then I explained why. Yes, it's not valid Verilog but we cannot detect this until we preprocess the input and...
@quantrpeter They correspond to the same token. If you open the generated `VerilogParser.tokens` or `VerilogLexer.tokens` file you will see that `VL` and `|` both have the same token ID (178).
@klcheungaj You're totally right about the newline character. It terminates the macro and shouldn't be allowed there. I'll fix this. **Edit:** According to the spec, white space is allowed between...
The rule is correct. `statement` following `else` can be another `if` statement, hence an `else if` statement.
> @AnirudhPotturi @KvanTTT @msagca should we close this PR? I think we can close this.
```antlr pictureString : ( pictureChars+ pictureCardinality? )+ ; pictureChars : DOLLARCHAR | IDENTIFIER | NUMERICLITERAL | SLASHCHAR | COMMACHAR | DOT | COLONCHAR | ASTERISKCHAR | DOUBLEASTERISKCHAR | LPARENCHAR |...
@kevinlano, In the [manual](https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&cad=rja&uact=8&ved=2ahUKEwjNprHG-pH7AhWzQ_EDHWxSCy0QFnoECBIQAQ&url=https%3A%2F%2Fpublic.support.unisys.com%2Faseries%2Fdocs%2Fclearpath-mcp-17.0%2Fpdf%2F86001518-316.pdf&usg=AOvVaw05VCJBlAALTTx5_xbvxGGK), on page 157, it says: ``` The allowable PICTURE clause symbols are A, B, I, N, P, S, V, X, Z, 0, 1, 9, slant (/),...
@kevinlano, I think I misunderstood the following description (on page 158). | Symbol | Function | |-|-| | I | Each I in the character string indicates that the nonblank...