Marc Rousavy
Marc Rousavy
Ohh, interesting! I'll try to fix the `getDefaultBitRate()` method by using `CamcorderProfile` instead of computing it on my own then!
Hey @j-jonathan! I spent some time investigating this and debugging the available `CamcorderProfiles`. I created this PR: https://github.com/mrousavy/react-native-vision-camera/pull/2216 which does two things: 1. It automatically chooses the best/recommended video bit-rate...
And I also added some more options: https://github.com/mrousavy/react-native-vision-camera/pull/2225
Released both in VisionCamera 3.6.11! :) If you appreciate my time and dedication in maintaining and improving this project, please consider [💖 sponsoring me on GitHub 💖](https://github.com/sponsors/mrousavy) so I can...
> In my case, it returns CamcorderProfile.QUALITY_4KDCI, and my phone only supports up to CamcorderProfile.QUALITY_2160P That is very weird - your Format is 4k (`{ ...other, "videoHeight": 2056, "videoWidth": 3648...
Yup okay thanks! I guess then I should edit the `getAvailableCameraDevices()` function to not return sizes that don't have a CamcorderProfile. So if your device supports a maximum CamcorderProfile of...
wtf, that's weird. So it says it's not supported, but actually is kinda supported? Maybe it's not supported in full bit-rate?
Would've been great if you could've created a PR for this. Anyways, I created a PR to fix this issue: #2389
Hey! I think this has already been fixed. If not, feel free to re-open :)
Okay update; it will not work like this. At least not with the Bridge, not sure if TurboModules will fix this. The problem is this code: https://github.com/facebook/react-native/blob/ce0dabddf369587311198290b5bfc8e058a39a28/packages/react-native/Libraries/BatchedBridge/NativeModules.js#L98-L162 It does not...