Marc Rousavy comments

Results 1816 comments of


                                            Marc Rousavy

Fix/fix third party ndk headers not found with REACT_NATIVE_DOWNLOADS_DIR setted

Can you confirm that the files are not unnecessarily being unzipped multiple times by addiing logs there?

Xcode Archive Error: Undefined symbols for WorkletRuntime::runGuarded 🔧

Awesome work tomasz!

Dual Capture not Possible🐛

This is not yet supported. There is a similar issue where I explained why, but I can't find it righgt now

'react/bridging/CallbackWrapper.h' file not found🔧

Hey - I think this is not related to VisionCamera. If it is, please create a PR to fix this

🐛 - Error while updating property 'cameraId' of a view managed by: CameraView

Hey! I think this is fixed already :)

🐛 Can't position square representing detected QR code frame properly

Hey - the CodeScanner now gives you a frame/bounding box as well, hope that helps.

🐛 Can't position square representing detected QR code frame properly

Yes exactly - using that you can figure out where exactly the Frame was scanned in, then convert that to screen coordinates yourself - no?

fix: App crashes when Camera using scanner is closed

> and forcing diff to be true can also resolve this issue Interesting, maybe the true fix can be in Difference? I'll take a look soon, thanks for your PR!

fix: App crashes when Camera using scanner is closed

Yea, the problem with the Main Thread approach is that this _queues_ the stop to be run on the Main Thread. The method `destroyPreviewOutputSync()` already returns, which tells Android "hey,...

🐛 `CameraDevice` contains formats that are not supported by `CamcorderProfile`

Interesting observation with the codec! Maybe there is a limit for the android recorder? Have you tried using a really low bitrate?