Marc Rousavy comments

Results 1816 comments of


                                            Marc Rousavy

🐛 Crash in Android release builds

Hey I think this is fixed in the latest version of Visioncamera.

Crash reports after switching to use AppGroups due to 0xdead10cc

I need full crash logs.

feat: Trigger Java GC on reload

@javache what do you think of putting it inside `ReactInstanceManager::tearDownReactContext`?

feat: Trigger Java GC on reload

Or I guess at the end of `ReactInstanceManager::recreateReactContextInBackground` - after that ran, `this.mCurrentReactContext` is also null, and it definitely looks like this is a better place for a "GC when...

feat: Trigger Java GC on reload

Okay I moved it to `recreateReactContextInBackground` and added a comment 👍 let me know if that makes sense EDIT: hmm actually I don't think this makes sense - for bridge...

feat: Trigger Java GC on reload

I just moved it into `DevSupportManagerBase.java::onReactInstanceDestroyed(...)`, what do you think about that? For me this always hits after refreshing in debug. In release, this isn't used afaik

feat: Trigger Java GC on reload

sorry for the bump here @javache - have you had a chance to look at this?

Simulate skew on Android

This is dope! Nice work @piaskowyk 🔥

[FEATURE] Handle non-image files gracefully with Blurhash.encode

Good feature request 👍 This should be simple to add in the native code, unfortunately I don't have any free time for such enhancements right now.

[BUG] Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'BlurhashModule' could not be found

cc @janicduplessis is react-native 0.73 supposed to be supported?