react-native-vision-camera icon indicating copy to clipboard operation
react-native-vision-camera copied to clipboard
verified publisher icon mrousavy

Fix/fix third party ndk headers not found with REACT_NATIVE_DOWNLOADS_DIR setted

Open changhuali opened this issue 2 years ago • 5 comments

What

After setting REACT_NATIVE_DOWNLOADS_DIR environment variable, rebuilding will be failed with follow reasons: image This is just because we forget to unzip the cached resources and copy them into the thirdPartyNdkDir dir

Changes

Remove the dependOn guard in prepareThirdPartyNdkHeaders task so that the prepare tasks could be done.

Tested on

  • Pixel 7 Pro emulator, SDK 34

Related issues

changhuali avatar Dec 09 '23 08:12 changhuali

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2023 8:42am

vercel[bot] avatar Dec 09 '23 08:12 vercel[bot]

Doesn't this run quite often then now? I think those steps are invoked very often, not just once...

mrousavy avatar Dec 11 '23 22:12 mrousavy

Can you confirm that the files are not unnecessarily being unzipped multiple times by addiing logs there?

mrousavy avatar Dec 11 '23 22:12 mrousavy

Can you confirm that the files are not unnecessarily being unzipped multiple times by addiing logs there?

This is the build log after gradle clean image This is the rebuild log with cache image And i found that the mtime of the unziped files in third-party-ndk had also not been changed, so i confirm that the files are not unnecessarily being unzipped multiple times

changhuali avatar Dec 13 '23 03:12 changhuali

Hi, should this pr be merged or closed?

changhuali avatar Dec 22 '23 02:12 changhuali