Martin Robinson

Results 446 comments of Martin Robinson

I was experimenting with this a bit and it seems that both LLVM and WixToolset do not add themselves to the PATH by default. LLVM can be configured when running...

I think we should go ahead with this and gradually switch to making winget the default for installing things, when possible.

> Not sure how feasible it is (to set up), but perhaps we could put up a small bug bounty to fix the upstream llvm issue? For someone who has...

> * Directly run `winget install` with `subprocess.run`. stdout and stdin are attached to the parent shell, so we can still interact with it (e.g. if we wanted to add...

Let's switch back to `dirs`. I have released a new version of `font-kit` doing this.

Perhaps the reason that tests are skipped could be integrated into the normal test output? ```diff diff --git a/python/wpt/grouping_formatter.py b/python/wpt/grouping_formatter.py index 29f8c7d64a..f093e0f892 100644 --- a/python/wpt/grouping_formatter.py +++ b/python/wpt/grouping_formatter.py @@ -124,7 +124,6...

> But I'm not clear on how I can modify the output for running a single test, since ServoFormatter does not appear to be used. I've been thinking about this...

Digging into this a big, the `MachFormatter` is included in the version of `mozlog` from pip, but also there is a modified version that ships with WPT. For some reason...

I modified this a bit to integrate the skipped reason inline. Let me know if this isn't up-to-snuff and I'll be happy to make a followup.

Nice work and great investigation! This looks good to me with the caveat below. I think it makes sense that @Loirooriol also looks at the change as well as he...