Martin Robinson

icon indicating a website link http://abandonedwig.info

icon company Igalia

Results 446 comments of Martin Robinson

Implement text-emphasis handling

@NeverHappened Any reason you need to clone the `TextDisplayItem` rather than just creating a new one with the properties calculated for the emphasis?

DevTools: Inspect node styles

Great work! I've pushed a new commit with some minor nits, but otherwise this looks good. I'll push to the MQ now.

shaping: Don't assume there's a space glyph when rendering tabs

I'll need to investigate these failures.

shaping: Don't assume there's a space glyph when rendering tabs

This one is ready to review.

Initial IndexedDB Support

Please squash you changes into a single commit (or organize them somehow, so that they are easier to review) and add @rasviitanen [as a co-author](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors) on these changes (since they...

Intermittent PASS in `/html/webappapis/update-rendering/child-document-raf-order.html`

@gterzian In the commit you can say "Fixes #issue_number" and this issue will be automatically closed which should mark the test as non-intermittent.

Add support for structured logging with tracing

Would it make sense to switch all of Servo from `log` to `tracing`?

script: Fix panic in `htmlimageelement.rs` using `str::find()` to find character boundaries.

This has the same failures that showed up in #32978, so maybe we can close this and discuss fixing them there?

script: Fix panic in `htmlimageelement.rs` using `str::find()` to find character boundaries.

@NotnaKO Thanks. Can you describe the changes you made in the PR body as well as the adaptations you had to make in `parse_a_srcset_attribute`? This will help make it easier...

script: Fix panic in `htmlimageelement.rs` using `str::find()` to find character boundaries.

> > @NotnaKO Thanks. Can you describe the changes you made in the PR body as well as the adaptations you had to make in `parse_a_srcset_attribute`? This will help make...