Martin Robinson
Martin Robinson
@atouchet Can you try running Servo with the fix from #32499 applied and report on your results?
Update, #32499 is now merged, so maybe you can just try on the latest from main @atouchet? Thank you!
I think this should be possible, but we should ensure that the WPT import job is also signing its commits.
This is done now. Thanks!
@jschwe No worries! I missed that the DCO Bot wasn't discussed in this issue. For the sake of clarity the Servo repository now enforces signing off commits via the [DCO...
That said: If there are some benefits to always using crossbeam channels while in single-process mode, I would be happy to change my mind.
One of the issues with the generic channel implementation is that there's a difference between what things can be sent over a crossbeam channel and what can be sent over...
@shanehandley Any reason this was closed? I had it on my todo list to review this.
I'm not sure we should replace every use of ipc::channel with GenericChannel. There are times that it is really useful to know what kind of channel you are dealing with...
Proposal: For now use this for situations when we need to write code that needs to communicate both in-process and out-of-process.