Michael Penkov
Michael Penkov
Does this actually achieve the goal of the PR? I think code in ldamodel.py enforces a minimum on the probability: https://github.com/RaRe-Technologies/gensim/blob/2131e3a3b0231c7eb0b0b447539d2ab7c8802633/gensim/models/ldamodel.py#L1313 So even if you specify zero, there's no guarantee...
@piskvorky @menshikh-iv I recall discussing this in another ticket/PR... what do you guys think? Personally, I think the enforcing line is misleading and can produce surprise for the user. If...
OK, reproduced on MacOS Python 3.9: ``` sergeyich:sqlitedict misha$ cat repro.py import tempfile from sqlitedict import SqliteDict def insert(): with tempfile.NamedTemporaryFile() as tmp: for j in range(100): with SqliteDict(tmp.name) as...
I think I've found the commit that caused the problem, now trying to work out why something so trivial is causing such a performance regression: ``` $ git bisect log...
Nah, look at how that variable is being used. There's a sleep loop that depends on it.
It's not quite the same functionality, because the superclass defines that variable and changes its value as it sees fit. ``` $ grep -B 10 _initialized /usr/local/Cellar/[email protected]/3.9.7/Frameworks/Python.framework/Versions/3.9/lib/python3.9/threading.py --max-count 1 class...
Basically, the problem itself isn't the commit in question. The problem is the way that sqlitedict is attempting to handle a race condition. The commit merely unmasks the problem. I...
Ping @Jwink3101 are you able to finish this PR?
Why not nest your dicts inside a dict? Your proposal: ```python db = sqlitedict.SqliteDictDb(dbfilename) dictionary_foo = db.get_dict("foo") dictionary_bar = db.get_dict("bar") ``` Nested alternative: ```python db = sqlitedict.SqliteDictDb(dbfilename) dictionary_foo = db['foo']...
Do we need to make an additional call? If yes, then I'd rather avoid doing unless it's absolutely necessary. Are you interested in making a PR?