Michael Penkov
Michael Penkov
Please add unit tests for your new functionaity.
Thank you for your interest in gensim and your effort. In it's current form, I don't think the contribution is a good fit for gensim, for the following reasons: -...
Another thing I've noticed is that the added functionality doesn't need to be part of the class it's being added to. The new functionality consists of two methods, but neither...
Ping @n8stringham : are you able to complete this PR?
@Jobtimize Thank you for drawing our attention to this. Are you interested in making a pull request to fix the issue?
> @mpenkov are we downloading these files regularly as part of our CI / testing? Sometimes. Not all of the gensim doctests code actually gets run. From what I understand,...
> And what determines whether something gets run or not? I had a closer look at the repo and it doesn't look like _anything_ is getting automatically doctested. My previous...
@kumar-neelabh Can you please add some tests for your new functionality?
Thank you for your contribution! Can you please add a unit test demonstrates the effect of your change?
@iiLaurens Ping. Are you able to complete this PR?