Michael Penkov

Results 254 comments of Michael Penkov

@piskvorky I think your interpretation is correct. @lambdamusic What is the memory usage like on the machine when you start having problems? I'm not sure about the implementation of multiprocessing.Pool....

@lambdamusic Did you manage to figure this out?

I think the reason is probably because nobody has requested this before. Are you interested in making a PR?

No, I think the idea was to rewrite the tests so they look like py.test ones instead of the standard library's unittest ones. Pytest has its own way of dealing...

Hi, had a brief look at the changes, looks like you're on the right track. Let me know when the code is ready for a review. Thanks!

@petedannemann Are you able to investigate?

@terencezl Are you able to finish this PR? It's almost done. If not, can you please enable "allow edits by maintainers"? If you're unable to finish, I will push it...

Fixed: https://travis-ci.org/github/RaRe-Technologies/smart_open/builds/729233945

Thank you for your contribution. Sorry it has taken so long for me to review this. Please have a look at the comments and get back to me.

@mrk-its Ping. Are you able to finish this PR?