Michael Penkov

Results 254 comments of Michael Penkov

@norbertgieruc What version of numpy did you upgrade to? Also, what O/S?

@piskvorky Something really strange is happening with numpy. In this ticket, the user is still unable to import gensim even after upgrading numpy to 1.20.2, when using Python 3.8.5 on...

> How come the wheels used numpy 1.20.1, when you switched to using oldest-supported-numpy? I don't understand how that can be. It could be a bug in oldest-supported-numpy. Its choice...

No, wait, the problem is that Windows builds happen using Appveyor, not Travis CI, and that uses a different build mechanism. This mechanism isn't picking up oldest-supported-numpy. I'll build new...

I think the Numpy ticket is still valid. We built the wheel using 1.20.1, and the user is unable to use it with numpy 1.20.2 installed. Is that expected? We...

> In our particular case, we're also using tensorflow 2.4.1, which fails when using numpy 1.20.x, so we seem to be in a difficult spot atm. Dependencies are fun, right?...

@norbertgieruc Can you please try gensim 4.0.1 and let us know whether the problem still persists?

Shouldn't we raise NotImplementedError instead of returning zero? It'd be less surprising for the user.

I've taken the liberty of adjusting the title. @gojomo Perhaps we can include a `strip_header_markup` keyword parameter (defaults to False) to handle both sides of the argument?